A lightweight fix for webofthings/webofthings.js#3.#7
A lightweight fix for webofthings/webofthings.js#3.#7franckOL wants to merge 8 commits intowebofthings:masterfrom
Conversation
|
Hi Franck, looking forward to testing this (probably this weekend), I also worked on a fix for that last weekend but used Watch.js so your solution looks more elegant. Thanks again! |
|
That's the branch with Watch.js btw: https://github.com/webofthings/webofthings.js/tree/observe |
|
Hi Frank, I did test it and it works very nicely on Node 6 but the WS subscription does not work anymore on Node 4. Note entirely sure why yet, did you check the tests on Node 4 (npm test)? Did it work for you? |
|
Hi Dominique, |
|
Hello, I made somechange. npm test works for Node 4 and node 6. Hope that's OK for 7 |
|
It looks great, thank! I had just seen that indeed somehow it always fell back to the custom defined ArrayObserver, not sure I understand why yet. Will test the code on the target devices (Pi) asap and will get back to you but this is looking promising! |
|
Hi Franck, I did test it on the hardware (Pi) and there is an issue: when a client listens for Websockets notifications about Actions (e.g., on/off), the actual Action handler (in |
chore(package): update uuid to version 3.0.0 (webofthings#8)
Another to try to fix #3. (ES6 compatibility)
It works for me, it's cleaner that last time